[Webkit-unassigned] [Bug 103727] Unset NodeMustGenerate flag for Call nodes of few String.prototype.* pure functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 27 05:02:29 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=103727





--- Comment #8 from Valery Ignatyev <valery.ignatyev at ispras.ru>  2013-11-27 05:00:54 PST ---
Created an attachment (id=217942)
 --> (https://bugs.webkit.org/attachment.cgi?id=217942&action=review)
patch for discussion

This is the preliminary patch posted to discuss the suggested approach.  Regarding your proposal to use intrinsics, we would like to implement more general approach. Please let us know any feedback.

Also, we have successfully used m_graph.deref(nodeIndex) to remove instructions from DFG in the older webkit, but at the moment this approach doesn't work.  Could you please suggest the correct way for removing instructions? In function  bool performRedundantCallElimination(Node *callNode) we've tried different combinations of
          callNode->clearFlags(NodeMustGenerate | NodeClobbersWorld);                                                                                       
          callNode->children.reset();                                                                                                           
          callNode->convertToPhantomUnchecked();                                                                      
          callNode->setRefCount(0)
without success.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list