[Webkit-unassigned] [Bug 124454] [Win] WebKit version in user agent string is incorrect.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124454


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217834|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #15 from Brent Fulgham <bfulgham at webkit.org>  2013-11-25 15:02:32 PST ---
(From update of attachment 217834)
View in context: https://bugs.webkit.org/attachment.cgi?id=217834&action=review

Looks great! You might want to omit the macro as I describe below. But it's fine as-is. R=me.

> Source/WebKit/win/WebView.cpp:2492
> +#if !USE(CAIRO)

I'm not sure that we need this macro at all. If WinCairo doesn't define BUILD_NUMBER it should just do the right thing. That way, you can define it yourself for future builds.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.