[Webkit-unassigned] [Bug 85994] [GStreamer] Seeking fails on media content provided by servers not supporting Range requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85994





--- Comment #57 from Andres Gomez Garcia <agomez at igalia.com>  2013-11-25 03:33:59 PST ---
(In reply to comment #54)
> (From update of attachment 217737 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217737&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:926
> > +        GST_DEBUG_OBJECT(src, "Seek in progress, ignoring response");
> 
> I think the locker should be unlocked before returning, no?

Added, and corrected a couple more.

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:932
> > +        if (200 == response.httpStatusCode()) {
> 
> I'm not sure this order of values is used elsewhere in WebKit. Usually we do something() == someConstant and not the opposite.

I discussed this with Martin and Carlos some time ago. There is no formal style rule about this but it seems that the most used is the one you said.

Changed for coherence, then ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.