[Webkit-unassigned] [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 24 19:01:42 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124325





--- Comment #49 from Darin Adler <darin at apple.com>  2013-11-24 19:00:09 PST ---
(In reply to comment #48)
> > Reindenting the whole file to make the style bot happy at the same time you make substantive changes to the file is not good, because the patch reviewer can’t easily see what the changes are. Please consider submitting a “reindent” patch first. That’s what people have done in similar situations before.
> 
> I agree with your sentiment. Should I do so for this patch as well? It is probably late to matter much for this patch.

Maybe others were able to review the changes to DragImage.h despite the re-indenting, but I didn’t really manage to do that. Since it seems others have reviewed I suppose we are OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list