[Webkit-unassigned] [Bug 124714] Instead of a large 'if' block, each failure class should write its own result in test_result_writer.py

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 21 19:21:44 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124714





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2013-11-21 19:20:16 PST ---
(From update of attachment 217564)
View in context: https://bugs.webkit.org/attachment.cgi?id=217564&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:153
>  class FailureMissingResult(TestFailure):
>      def message(self):
>          return "-expected.txt was missing"
>  
> +    def write_failure(self, writer, driver_output, expected_driver_output, port):
> +        writer.write_text_files(driver_output.text, expected_driver_output.text)
> +        writer.create_text_diff_and_write_result(driver_output.text, expected_driver_output.text)

Can we create a common superclass of FailureMissingResult and FailureTextMismatch to share the code here?

> Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:247
> +    def write_failure(self, writer, driver_output, expected_driver_output, port):
> +        writer.write_audio_files(driver_output.audio, expected_driver_output.audio)
> +

Ditto about extracting a common superclass for FailureMissingAudio and FailureAudioMismatch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list