[Webkit-unassigned] [Bug 124731] New: check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 21 11:47:19 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=124731
Summary: check-webkit-style is wrong about expected format
parameter pack rvalue reference arguments
Product: WebKit
Version: 528+ (Nightly build)
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: beidson at apple.com
check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
Noticed in a patch attached to https://bugs.webkit.org/show_bug.cgi?id=124698
The complaints were:
Source/WebKit2/Shared/AsyncRequest.h:44: Missing spaces around && [whitespace/operators] [3]
Source/WebKit2/Shared/AsyncRequest.h:70: Missing spaces around && [whitespace/operators] [3]
Source/WebKit2/Shared/AsyncRequest.h:91: Missing spaces around && [whitespace/operators] [3]
The lines in question are:
template<typename... Arguments> void requestCompleted(Arguments&&... arguments);
void requestCompleted(Arguments&&... arguments)
template<typename... Arguments> void AsyncRequest::requestCompleted(Arguments&&... arguments)
The script must be detecting && as the 'boolean and' operator. The formatting in this patch is actually correct/preferred.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list