[Webkit-unassigned] [Bug 124730] New: check-webkit-style is wrong about expected format for std::function function arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124730

           Summary: check-webkit-style is wrong about expected format for
                    std::function function arguments
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: beidson at apple.com


check-webkit-style is wrong about expected format for std::function variables.

Seen in the patch(es) attached to https://bugs.webkit.org/show_bug.cgi?id=124698 -

Source/WebKit2/Shared/AsyncRequest.h:60:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/Shared/AsyncRequest.h:78:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/Shared/AsyncRequest.h:89:  Extra space before ( in function call  [whitespace/parens] [4]


The lines in question are:
    static PassRefPtr<AsyncRequest> create(std::function<void (Arguments...)> completionHandler)
    AsyncRequestImpl(std::function<void (Arguments...)> completionHandler)
    std::function<void (Arguments...)> m_completionHandler;

The style-checker needs to know that when "something that looks like a function decl/def" is inside std::function<> brackets, the space before the paren is expected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.