[Webkit-unassigned] [Bug 124722] New: [EFL] X11Helper::createPixmap doesn't initialise out value handleId

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124722

           Summary: [EFL] X11Helper::createPixmap doesn't initialise out
                    value handleId
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit EFL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.pena at samsung.com
                CC: demarchi at webkit.org


Both 

void X11Helper::createPixmap(Pixmap* handleId, const XVisualInfo& visualInfo, const IntSize& size) and 
void X11Helper::createPixmap(Pixmap* handleId, const EGLint id, bool hasAlpha, const IntSize& size) 

don't initialise the out parameter handleId.

The problem with that is that these functions do early returns under certain error situations, so clients using them could be checking an invalid value for handleId. At the moment, this is only call from EGLXSurface.cpp and GLXSurface.cpp, and while they could initialise themselves the argument before the call, I think that is error prone. I propose doing an early initialisation in createPixmap just to be on the safe side.

Patch following now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.