[Webkit-unassigned] [Bug 124579] Use unsigned consistently, and check for invalid casts when calling into SharedBuffer from other code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124579


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217544|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #34 from Alexey Proskuryakov <ap at webkit.org>  2013-11-21 09:27:43 PST ---
(From update of attachment 217544)
View in context: https://bugs.webkit.org/attachment.cgi?id=217544&action=review

There are even more threads that need to be pulled :(

See for example this line in WebCoreResourceHandleAsDelegate.mm:

    m_handle->client()->willStopBufferingData(m_handle, (const char*)[data bytes], static_cast<int>([data length]));

willStopBufferingData is the first and only name I grepped for, so probabilistically speaking, there are likely more implicit casts remaining. Please grep WebCore for every function name you changed.

> Source/WebCore/loader/ResourceLoader.cpp:1
> -/*
> + /*

Accidental change here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.