[Webkit-unassigned] [Bug 123406] check-webkit-style should support C++11 rvalue references
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 20 23:21:16 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=123406
Brent Fulgham <bfulgham at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #217418|review-, commit-queue? |review+, commit-queue+
Flag| |
--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> 2013-11-20 23:19:48 PST ---
(From update of attachment 217418)
View in context: https://bugs.webkit.org/attachment.cgi?id=217418&action=review
R=me
>>> Tools/Scripts/webkitpy/style/checkers/cpp.py:2626
>>> + if cleansed_line.strip().endswith('||') or cleansed_line.strip().endswith(' &&'):
>>
>> Won't strip() remove all the whitespace? Will we ever match ' &&'?
>
> stip() method only remove the leading end trailing whitespaces. It won't remove the whitespace before '&&'. Just to be sure a i checked it before i uploaded the patch. End already exists a test that check the multiline conditions (last assert in 'test_brace_at_begin_of_line').
Great! Thanks for confirming.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list