[Webkit-unassigned] [Bug 124679] [WinCairo] Building ANGLE libraries fails.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124679





--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org>  2013-11-20 14:49:21 PST ---
Attachment 217483 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/libEGL.vcxproj', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/libEGL.vcxproj.filters', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/libGLESv2.vcxproj', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/libGLESv2.vcxproj.filters', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/translator_common.vcxproj', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/translator_common.vcxproj.filters', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/translator_glsl.vcxproj', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/translator_glsl.vcxproj.filters', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/translator_hlsl.vcxproj', u'Source/ThirdParty/ANGLE/ANGLE.vcxproj/translator_hlsl.vcxproj.filters', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/src/libGLESv2/constants.h', u'Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2.def']" exit_code: 1
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:9:  #ifndef header guard has wrong style, please use: constants_h  [build/header_guard] [5]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:13:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:16:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:17:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:18:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:21:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:24:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:25:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:28:  ALIASED_LINE_WIDTH_RANGE_MIN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:29:  ALIASED_LINE_WIDTH_RANGE_MAX is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/constants.h:30:  ALIASED_POINT_SIZE_RANGE_MIN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 11 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.