[Webkit-unassigned] [Bug 124326] Web Inspector: implement Page.captureScreenshot in the backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124326





--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-11-18 15:28:22 PST ---
(From update of attachment 217242)
View in context: https://bugs.webkit.org/attachment.cgi?id=217242&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * WebCore.xcodeproj/project.pbxproj:

Say what you did.

> Source/WebInspectorUI/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=124326
> +
> +        Reviewed by NOBODY (OOPS!).

Ditto.

> Source/WebKit/mac/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * WebCoreSupport/WebInspectorClient.h:

Ditto.

> Source/WebKit2/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:

Ditto.

> Source/WebCore/inspector/InspectorClient.h:91
> +    virtual bool capturePageSnapshot(int, int, int, int, bool, String*) { return false; }

You should name those ints (put the  parameter names in comments). Can it be a rect?

> Source/WebCore/inspector/InspectorPageAgent.h:132
> +    virtual void capturePageSnapshot(ErrorString*, const int* x, const int* y, const int* width, const int* height, const bool* usePageCoordinates, String* outData);

What are x and y relative to? Document? Frame? Viewport?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.