[Webkit-unassigned] [Bug 124404] [AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124404





--- Comment #3 from Mario Sanchez Prada <mario at webkit.org>  2013-11-18 03:25:54 PST ---
(From update of attachment 217040)
View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review

> Source/WebCore/accessibility/AXObjectCache.h:-64
> -    AXComputedObjectAttributeCache() { }
> -

Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.