[Webkit-unassigned] [Bug 102647] [CMake] Add an option to build AllInOne files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 13:16:26 PST 2013


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
 Attachment #217046|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #10 from Patrick R. Gansterer <paroga at paroga.com>  2013-11-15 13:15:02 PST ---
(From update of attachment 217046)
View in context: https://bugs.webkit.org/attachment.cgi?id=217046&action=review

i'd suggest a WebCore_ALLINONE_SOURCES variable and handle it in the WEBKIT_WRAP_SOURCES macro.
do the many status messages provide a real benefit? they look a kind of printf-debugging to me (just for implementing the allinone stuff for cmake)

> Source/WebCore/CMakeLists.txt:2558
> +set(AllInOne "" CACHE STRING "If true, enables all-in-one files.")

if its a global switch it should be move to the root cmake file

> Source/WebCore/CMakeLists.txt:2559
> +if (AllInOne)

usually global variables are all uppercase

> Source/WebCore/CMakeLists.txt:2592
> +    #list(GET allInOnes 0 allInOne)

remove comment?

> Source/WebCore/CMakeLists.txt:2601
> +    endforeach (allInOne)

please remove the characters from the ()

> Source/WebCore/CMakeLists.txt:2602
> +endif (AllInOne)


> Source/cmake/AllInOneSupport.cmake:1
> +cmake_minimum_required(VERSION 2.8)

imho not a good idea to spred this across the whole code

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list