[Webkit-unassigned] [Bug 124401] [EFL] Leak in ewk_frame_certificate_status_get()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124401





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-15 04:51:40 PST ---
(From update of attachment 217033)
View in context: https://bugs.webkit.org/attachment.cgi?id=217033&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:1705
> -    SoupMessage* soupMessage = documentLoader->request().toSoupMessage();
> +    GRefPtr<SoupMessage> soupMessage(adoptGRef(documentLoader->request().toSoupMessage()));
>  
> -    if (soupMessage && (soup_message_get_flags(soupMessage) & SOUP_MESSAGE_CERTIFICATE_TRUSTED))
> +    if (soupMessage && (soup_message_get_flags(soupMessage.get()) & SOUP_MESSAGE_CERTIFICATE_TRUSTED))

I think you could even avoid to create the soup message object by simply using 

if (documentLoader->request().soupMessageFlags() & SOUP_MESSAGE_CERTIFICATE_TRUSTED)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.