[Webkit-unassigned] [Bug 124209] [Cairo] Avoid extra copy when drawing images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124209


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216687|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2013-11-14 11:03:08 PST ---
(From update of attachment 216687)
View in context: https://bugs.webkit.org/attachment.cgi?id=216687&action=review

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:181
> +    if (srcRect.x() || srcRect.y()
> +        || srcRect.width() != cairo_image_surface_get_width(surface)
> +        || srcRect.height() != cairo_image_surface_get_height(surface)) {

There is no guarantee that this surface is an image surface. You could simplify this check to be:
if (srcRect.x() || srcRect.y() || srcRect.size() == cairoSurfaceSize(surface))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.