[Webkit-unassigned] [Bug 99065] [GStreamer] Add support for Media Source API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99065





--- Comment #61 from Philippe Normand <pnormand at igalia.com>  2013-11-13 08:04:20 PST ---
(From update of attachment 216796)
View in context: https://bugs.webkit.org/attachment.cgi?id=216796&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:158
> +    gst_element_set_state(element, GST_STATE_PLAYING);

Hum is this really needed? Syncing the state with parent's should be enough.

> Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:191
> +static void webKitMediaSrcDispose(GObject* object)
> +{
> +    GST_CALL_PARENT(G_OBJECT_CLASS, dispose, (object));
> +}

No need to have this if all the function does is chaining to parent, I guess :)

> Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:334
> +        if (priv->sourceAudio.appsrc) {
> +            gst_app_src_set_caps(GST_APP_SRC(priv->sourceAudio.appsrc), 0);
> +            if (!seeking)
> +                gst_app_src_set_size(GST_APP_SRC(priv->sourceAudio.appsrc), -1);
> +        }

Dedent this block?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.