[Webkit-unassigned] [Bug 124199] Fixed unused parameter warnings in WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124199


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216788|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Csaba Osztrogonac <ossy at webkit.org>  2013-11-13 03:49:52 PST ---
(From update of attachment 216788)
View in context: https://bugs.webkit.org/attachment.cgi?id=216788&action=review

LGTM, r=me. I'll fix the style issue mentioned before landing.

> Source/WebCore/platform/graphics/WidthIterator.cpp:134
> +#else
> +        UNUSED_PARAM(iterator);
>  #endif
>          fontData->applyTransforms(glyphBuffer->glyphs(lastGlyphCount), advances + lastGlyphCount, glyphBufferSize - lastGlyphCount, typesettingFeatures);

This code is so ugly ... :-/

Maybe we should reorder it a little bit:
#if !ENABLE(SVG_FONTS)
     UNUSED_PARAM(iterator);
#else
    // We need to handle transforms on SVG fonts internally, since they are rendered internally.
    if 
    ....
    } else
#endif
        fontdata->applyTransforms(...);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.