[Webkit-unassigned] [Bug 119273] Arithmetic overflow when computing max-height CSS property with subpixel layout

Tue Nov 12 14:02:18 PST 2013

https://bugs.webkit.org/show_bug.cgi?id=119273

--- Comment #13 from Martin Robinson <mrobinson at webkit.org>  2013-11-12 14:00:58 PST ---
(From update of attachment 215496)
View in context: https://bugs.webkit.org/attachment.cgi?id=215496&action=review

> Source/WTF/wtf/FeatureDefines.h:294
> +#if !defined(ENABLE_SATURATED_LAYOUT_ARITHMETIC)
> +#define ENABLE_SATURATED_LAYOUT_ARITHMETIC 1
> +#endif
> +

Let's just enable it via build-webkit and in SetupWebKitFeatures.m4 and avoiding changing this file for now.  Hopefully we can remove the flag shortly.

> LayoutTests/fast/css/max-height-huge-value-expected.html:2
> +<html lang="en">

Do you need the lang tag here?

> LayoutTests/fast/css/max-height-huge-value-expected.html:10
> +      width: 100px;
> +      border: 2px solid blue;
> +      overflow: hidden;
> +      max-height: 20000000px;
> +    }

Bit of a nit, but this indentation is irregular.

> LayoutTests/platform/gtk/TestExpectations:-1384
> -webkit.org/b/118595 fast/regions/auto-size/autoheight-correct-region-for-lines-2.html [ ImageOnlyFailure ]
> -

Does this test already cover the failure. If so, you may not need a new test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.