[Webkit-unassigned] [Bug 124180] GStreamer source files should be included in Windows build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 13:21:27 PST 2013


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #216630|review?                     |review-
               Flag|                            |

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2013-11-12 13:20:08 PST ---
(From update of attachment 216630)
View in context: https://bugs.webkit.org/attachment.cgi?id=216630&action=review

This seems fine, but please exclude them from the Apple port build to reduce confusion.

> Source/WTF/WTF.vcxproj/WTF.vcxproj:78
> +    <ClCompile Include="..\wtf\gobject\GRefPtr.cpp" />

These need to be marked as "don't build" on non-WinCairo ports.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:7261
> +    <ClCompile Include="..\platform\graphics\gstreamer\WebKitWebSourceGStreamer.cpp" />

These should be excluded as well.  I know that they don't compile due to the USE(GSTREAMER) guards, but it might confuse someone who thinks GStreamer is being used under the Apple port.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list