[Webkit-unassigned] [Bug 123439] Fix reported build warnings for GTK
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 12 08:26:14 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=123439
Carlos Garcia Campos <cgarcia at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #216670|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> 2013-11-12 08:24:55 PST ---
(From update of attachment 216670)
View in context: https://bugs.webkit.org/attachment.cgi?id=216670&action=review
You can use Tools/Scripts/prepare-ChangeLog script instead of manually creating the changelog entry to make sure it's correct.
> Source/WebCore/ChangeLog:4
> + https://bugs.webkit.org/show_bug.cgi?id=123439#c4
Remove the #c4.
> Source/WebCore/ChangeLog:6
> + There was a void method, that has return value in it's documentation, so I removed it.
I said *after* the Reviewed by line, not before. Sorry to be so nitpicking but I'm not sure commit-queue will be able to land the patch if the changelog is not correctly formatted.
> Source/WebCore/ChangeLog:8
> + Reviewed by NOBODY (OOPS!).
I already r+'ed the patch, you can fill this with my name and upload a new version of the patch asking only commit-queue?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list