[Webkit-unassigned] [Bug 123439] Fix reported build warnings for GTK

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 06:54:05 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=123439


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216668|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-12 06:52:47 PST ---
(From update of attachment 216668)
View in context: https://bugs.webkit.org/attachment.cgi?id=216668&action=review

Thanks for the patch, there are a couple of problems with the ChangeLog.

> Source/WebCore/ChangeLog:3
> +        There was a void method, that has return value in it's documentation, so I removed it.

This line should contain the bug title, add your explanation below, after the Reviewed by line.

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

You should remove this line about the new tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list