[Webkit-unassigned] [Bug 123333] [curl] Add file cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 05:35:24 PST 2013


Mátyás Mustoha <mmatyas at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
 Attachment #216378|                            |review?, commit-queue?
               Flag|                            |

--- Comment #6 from Mátyás Mustoha <mmatyas at inf.u-szeged.hu>  2013-11-08 05:34:09 PST ---
Created an attachment (id=216378)
 --> (https://bugs.webkit.org/attachment.cgi?id=216378&action=review)
Proposed patch 2

Thanks for the detailed review! I fixed the issues you've mentioned.

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:90
> +    long long filesize = -1;

I've used "long long" because getFileSize() in FileSystem.h expects a long long variable as parameter:
bool getFileSize(const String&, long long& result);

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list