[Webkit-unassigned] [Bug 124030] New: Update an out-dated ASSERT in IconDatabase code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124030

           Summary: Update an out-dated ASSERT in IconDatabase code
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: InRadar
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: beidson at apple.com


Update an out-dated ASSERT in IconDatabase code

The ASSERT in IconDatabase.cpp:
    ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal));
... was added when the IconDatabase interface was largely synchronous and only about WebKit1

With the asynchronous interfaces that have been added and the support for WK2 that has been added, the ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed.

It should be updated to:
    ASSERT(iconRecord || databaseCleanupCounter || m_retainedPageURLs.contains(pageURLOriginal));

In radar as <rdar://problem/15171118>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.