[Webkit-unassigned] [Bug 123859] Remove npr.org specific hack in HTMLMediaElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 7 11:40:53 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=123859





--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2013-11-07 11:39:39 PST ---
The hack was added because the npr.org <audio> player had code that called play() when it got a 'canplay' event. The code was essentially:

NPR.StaticEmbedAudio.audio_player.addEventListener('canplay',function() {
    NPR.StaticEmbedAudio.audio_duration=NPR.StaticEmbedAudio.audio_player.duration;
    NPR.StaticEmbedAudio.updateDuration(NPR.StaticEmbedAudio.audio_duration);
    NPR.StaticEmbedAudio.audio_ready=true;
    NPR.StaticEmbedAudio.audio_player.play();
}, true);

The WebKit changes in r57820 caused the 'canplay' event to be fired when the src attribute was set from JS, which caused all <audio> elements on their site to begin playing automatically. The npr.org player has been changed, so we should remove the code added in r58586.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list