[Webkit-unassigned] [Bug 123810] Avoid invalid cairo matrix when drawing surfaces too small

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123810


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216184|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-11-07 10:48:25 PST ---
(From update of attachment 216184)
View in context: https://bugs.webkit.org/attachment.cgi?id=216184&action=review

Thanks! One small nit in the patch.

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:164
>      FloatRect srcRect = originalSrcRect;
>  
> +    // Avoid invalid cairo matrix with small values.
> +    if (std::fabs(destRect.width()) < 0.5f || std::fabs(destRect.height()) < 0.5f)
> +        return;
> +

Please move this above the definition of srcRect, as srcRect is only used afterward.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.