[Webkit-unassigned] [Bug 123879] Ended event should be triggered also when playback rate is negative

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123879


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216149|review?                     |review+
               Flag|                            |




--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2013-11-06 10:55:35 PST ---
(From update of attachment 216149)
View in context: https://bugs.webkit.org/attachment.cgi?id=216149&action=review

> LayoutTests/media/video-ended-event-negative-playback.html:17
> +                    function ()
> +                    {
> +                        video.currentTime = 2;
> +                        video.playbackRate = -1;
> +                        video.play();
> +                        failTestIn(2500);
> +                    });

This test will always take at least 2 seconds to complete.This seems excessive, can you make it something like .5 instead?

> Source/WebCore/html/HTMLMediaElement.cpp:3679
>      double dur = duration();

Nit: can you please get rid of the "dur" abbreviation while you are here: double duration = this->duration();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.