[Webkit-unassigned] [Bug 123899] [GTK] Use deprecation guards around deprecated API in GObject DOM bindings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 09:50:08 PST 2013


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #216185|review?                     |review+
               Flag|                            |

--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-11-06 09:48:55 PST ---
(From update of attachment 216185)
View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review

Looking good, with one small nit about the comment style.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009
> +        push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");

See below.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234
> +        push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");

See below.

> Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167

I think we typically use C++ style comments for this sort of thing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list