[Webkit-unassigned] [Bug 118969] [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118969





--- Comment #8 from Mario Sanchez Prada <mario at webkit.org>  2013-11-06 01:59:44 PST ---
(From update of attachment 216039)
View in context: https://bugs.webkit.org/attachment.cgi?id=216039&action=review

Looks good, except some nitpicks that would be great to fix. Same considerations apply to WKTR

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:374
> +    for (Vector<AccessibilityUIElement>::iterator it = elements.begin(); it != elements.end(); ++it) {

Sorry I haven't realized of this first, but as you don't need to modify this object, you can use const_iterator here instead

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:387
> +

I think this blank line is not needed

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:399
> +

Ditto

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:406
> +static Vector<AccessibilityUIElement> getVisibleCells(AccessibilityUIElement* uiElement)

In this file, we normally call this parameter "element", not "uiElement"

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:987
> +

Extra line not needed

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:997
> +

Ditto.

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1019
> +

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.