[Webkit-unassigned] [Bug 107941] Add support to upload to gist in webkit-patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 5 09:12:14 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107941





--- Comment #9 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-11-05 09:11:00 PST ---
(From update of attachment 216028)
View in context: https://bugs.webkit.org/attachment.cgi?id=216028&action=review

> Tools/Scripts/webkitpy/tool/commands/gist.py:2
> +# Copyright (c) 2009, 2011 Google Inc. All rights reserved.
> +# Copyright (c) 2009 Apple Inc. All rights reserved.

Is this really correct?

> Tools/Scripts/webkitpy/tool/steps/uploadanonymousgist.py:1
> +# Copyright (C) 2010 Google Inc. All rights reserved.

Is the copyright information really correct?

> Tools/Scripts/webkitpy/tool/steps/uploadanonymousgist.py:42
> +    def options(cls):
> +        return AbstractStep.options()

This is not needed AbstractStep is the base class for this.

> Tools/Scripts/webkitpy/tool/steps/uploadanonymousgist.py:59
> +            req = urllib2.Request(url, gist_data)
> +            res = urllib2.urlopen(req)

Please do not abbreviate the variable names: 'req' -> 'request' and 'res' -> 'result'

> Tools/Scripts/webkitpy/tool/steps/uploadanonymousgist.py:60
> +            new_gist = json.loads(res.read())

Are we really sure that the result is always json?

> Tools/Scripts/webkitpy/tool/steps/uploadanonymousgist.py:66
> +                exit(1)

I think we should use the base class' _exit method for this.

> Tools/Scripts/webkitpy/tool/steps/uploadanonymousgist.py:68
> +            print('Something went worng')

Typo: 'worng'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list