[Webkit-unassigned] [Bug 123791] [GStreamer] Playback rate is ommitted when seeking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123791


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216019|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Philippe Normand <pnormand at igalia.com>  2013-11-05 05:42:28 PST ---
(From update of attachment 216019)
View in context: https://bugs.webkit.org/attachment.cgi?id=216019&action=review

Looks good but I have some nits about the test. Can you please fix them?

> LayoutTests/media/video-seek-with-negative-playback.html:1
> +<video></video>

<video/>
It'd be good to make this a normal html file with the usual head and body too.

> LayoutTests/media/video-seek-with-negative-playback.html:8
> +        function ()

The coding style is not very consistent about curly braces. Can the test be refactored to avoid the nested waitForEvent()s?

> LayoutTests/media/video-seek-with-negative-playback.html:16
> +                    if ( lastTime == -1) {

empty space

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.