[Webkit-unassigned] [Bug 123794] HTMLCollection should not be NodeList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123794





--- Comment #3 from Andreas Kling <akling at apple.com>  2013-11-05 02:19:02 PST ---
(From update of attachment 216016)
View in context: https://bugs.webkit.org/attachment.cgi?id=216016&action=review

> Source/WebCore/dom/Document.cpp:502
> +    for (unsigned i = 0; i < WTF_ARRAY_LENGTH(m_nodeListAndCollectionCounts); i++)

++i LOL

> Source/WebCore/dom/Document.cpp:592
> +    for (unsigned i = 0; i < WTF_ARRAY_LENGTH(m_nodeListAndCollectionCounts); i++)

Ditto.

> Source/WebCore/dom/Document.cpp:3361
> +void Document::registerNodeList(LiveNodeList* list)

LiveNodeList&

> Source/WebCore/dom/Document.cpp:3368
> +void Document::unregisterNodeList(LiveNodeList* list)

LiveNodeList&

> Source/WebCore/dom/Document.cpp:3377
> +void Document::registerCollection(HTMLCollection* list)

HTMLCollection&
Also 'list'?

> Source/WebCore/dom/Document.cpp:3386
> +{

HTMLCollection&
Also 'list'?

> Source/WebCore/dom/Document.h:704
> +    bool shouldInvalidateNodeListAndCollectionCaches(const QualifiedName* attrName = 0) const;

nullptr

> Source/WebCore/dom/LiveNodeList.cpp:43
> +inline bool isMatchingElement(const NodeListType*, Element*);

So

> Source/WebCore/dom/LiveNodeList.cpp:45
> +template <> inline bool isMatchingElement(const LiveNodeList* nodeList, Element* element)

many

> Source/WebCore/dom/LiveNodeList.cpp:50
> +template <> inline bool isMatchingElement(const HTMLTagNodeList* nodeList, Element* element)

pointers

> Source/WebCore/dom/LiveNodeList.cpp:55
> +template <> inline bool isMatchingElement(const ClassNodeList* nodeList, Element* element)

everywhere :|

> Source/WebCore/dom/LiveNodeList.cpp:67
> +    return 0;

nullptr

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.