[Webkit-unassigned] [Bug 123703] Add helpers for partial descendant traversal to element iterators

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123703





--- Comment #2 from Andreas Kling <akling at apple.com>  2013-11-03 02:39:02 PST ---
(From update of attachment 215858)
View in context: https://bugs.webkit.org/attachment.cgi?id=215858&action=review

> Source/WebCore/editing/FrameSelection.cpp:1964
> +        if (element.hasTagName(frameTag) || element.hasTagName(iframeTag)) {

We should use isHTMLFrameElement() and isHTMLIFrameElement() here.

> Source/WebCore/html/HTMLFormElement.cpp:485
> +        if (!element.isFormControlElement() && !element.hasTagName(objectTag))

isHTMLObjectElement()

> Source/WebCore/html/HTMLFormElement.cpp:740
> +    if (!startElement.parentElement())
> +        return nullptr;
> +    return lineageOfType<HTMLFormElement>(*startElement.parentElement()).first();

This would be even simpler with ancestorsOfType.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.