[Webkit-unassigned] [Bug 70117] Expose HTMLCanvasElement supportsContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70117


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at webkit.org




--- Comment #21 from Sam Weinig <sam at webkit.org>  2013-05-31 14:57:51 PST ---
(In reply to comment #19)
> (From update of attachment 203462 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203462&action=review
> 
> >> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:123
> >> +            if (jsAttrs->hasProperty(exec, preserveDrawingBuffer))
> > 
> > These toBooleans() can all throw exceptions, so we should probably be checking for exceptions.  We should also make sure we are testing all those cases as well.  Can this use a JSDictionary to simplify things?
> 
> Right now JSHTMLCanvasElement::getContext is implemented like this (without exception handling) - should I still add exception handling?

You should add the checking, yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.