[Webkit-unassigned] [Bug 117081] DerivedSources.make: any rules that use $(FEATURE_DEFINES) should be rebuilt when FeatureDefines.xcconfig changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117081


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CSSGrammar.{cpp|h} should   |DerivedSources.make: any
                   |be rebuilt when             |rules that use
                   |FeatureDefines.xcconfig     |$(FEATURE_DEFINES) should
                   |changes                     |be rebuilt when
                   |                            |FeatureDefines.xcconfig
                   |                            |changes
                 CC|                            |laszlo.gombos at webkit.org,
                   |                            |mrowe at apple.com,
                   |                            |sam at webkit.org




--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2013-05-31 09:28:45 PST ---
After looking at use of $(FEATURE_DEFINES) in DerivedSources.make, I realized that any rule that uses $(FEATURE_DEFINES) to process files should be re-run if Configurations/FeatureDefines.xcconfig changes.

The alternative is to do a full clean world build when this happens (or randomly delete generated files until the build works).

It's also possible to split up FeatureDefines.xcconfig into pieces (one for CSS features, etc.) so that only the file with the related features needs to have a make rule dependency.  However, it's already hard enough to keep FeatureDefines.xcconfig in sync across all four projects (JavaScriptCore, WebCore, WebKit, WebKit2), so splitting it into N files would make that problem (4 * N) times worse.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.