[Webkit-unassigned] [Bug 117001] WebKit's Enter Full Screen for <video> elements isn't working

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117001


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203372|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Jer Noble <jer.noble at apple.com>  2013-05-30 12:59:58 PST ---
(From update of attachment 203372)
View in context: https://bugs.webkit.org/attachment.cgi?id=203372&action=review

> Source/WebCore/dom/Document.cpp:4980
> +    UserGestureIndicator indicator(DefinitelyProcessingNewUserGesture);
> +    

By inserting this UserGestureIndicator, this patch would disable the security requirement that full screen requests must begin with an event handler.  The appropriate place to put this line is in your context menu handler, immediately before calling element->webkitRequestFullScreen(), not inside requestFullScreenForElement() itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.