[Webkit-unassigned] [Bug 117039] [GStreamer] Support audio and video tracks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 30 12:14:06 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117039





--- Comment #6 from Brendan Long <b.long at cablelabs.com>  2013-05-30 12:12:36 PST ---
This patch isn't as nice as I'd like yet, but it shows the approach I'm taking.

  * Added new callbacks to VideoTrackPrivateClient and AudioTrackPrivateClient to let it notify when the track's enabled/selected state changed, and when there's a label and language.

  * VideoTrack and AudioTrack call `m_private->set{Selected,Enabled}()` in their `set{Selected,Enabled}()` functions.

  * I split MediaPlayerPrivateGStreamer::videoChanged() into two functions: videoChanged and videoCapsChanged.

  * The {Audio,Video}TrackPrivateGStreamer classes take a pad and a playbin, and then monitor their own state (adding notify::active and notify::tags callbacks to their pad). For some reason these functions are both failing: notify::active never seems to happen, and notify::tags causes segfaults.

I think it may help to setup the video and audio tracks in the videoChanged() and audioChanged() functions, then just notify on them in notifyPlayerOfAudio() and notifyPlayerOfVideo()..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list