[Webkit-unassigned] [Bug 116686] [Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116686


Alberto Garcia <agarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203367|                            |review?, commit-queue?
               Flag|                            |




--- Comment #4 from Alberto Garcia <agarcia at igalia.com>  2013-05-30 11:21:00 PST ---
Created an attachment (id=203367)
 --> (https://bugs.webkit.org/attachment.cgi?id=203367&action=review)
Patch

(In reply to comment #3)
> Memory is not leaking because buffer is a GRefPtr.

Yes, you're right.

This patch removes the assertion and returns the buffer if it
exists. I don't see any other crash or assertion being triggered and
everytime a new buffer is created it seems to be cleared correctly
afterwards.

Then we have the thing that the requestedSize parameter is completely
ignored if the buffer already exists, although in practice this is not
happening since we're using a constant value that is defined in
ResourceHandle::ensureReadBuffer()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.