[Webkit-unassigned] [Bug 116686] [Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116686





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-30 10:58:10 PST ---
(In reply to comment #2)
> I actually don't understand why that assert is there, either it is
> wrong or the name of the method is misleading, because it's creating a
> new buffer every time (and we're most likely leaking memory).

Memory is not leaking because buffer is a GRefPtr. 

> This is called from ResourceHandle::ensureReadBuffer(), which is used
> by several callbacks in ResourceHandle.
> 
> This comes from bug 115364 and bug 105552.

Patch in bug 115364 doesn't change the logic of the gst buffer, it simply renames the method and moves the default buffer implementation from the cross platform code to the soup resource handle implementation

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.