[Webkit-unassigned] [Bug 115647] [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115647





--- Comment #24 from Mario Sanchez Prada <mario at webkit.org>  2013-05-30 05:29:22 PST ---
(From update of attachment 203340)
View in context: https://bugs.webkit.org/attachment.cgi?id=203340&action=review

Patch looks good to me. I just found a couple of minor nits that I've commented about below...

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:813
> +        if (!core(object))
> +            return 0;
> +
> +        // TODO: Should we fall back on lang xml:lang when the following comes up empty?
> +        String language = core(object)->language();

Small nit: you can have a coreObject variable and only call core(object) once here.

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:818
> +        const gchar *locale = 0;

Misplaced *: gchar * -> gchar*

Also, I think the current style rules prefer char* to gchar* for non-public code.

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:435
> +    const gchar *locale = atk_object_get_object_locale(ATK_OBJECT(m_element));

Same considerations than above

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:593
> +    const gchar *locale = atk_object_get_object_locale(ATK_OBJECT(m_element.get()));

And yet again... :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.