[Webkit-unassigned] [Bug 116978] [GTK] Needs to check for harfbuzz-icu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116978





--- Comment #3 from Emilio Pozuelo Monfort <pochu27 at gmail.com>  2013-05-30 04:19:12 PST ---
I don't have harfbuzz 0.9.18 yet so not now.

The patch looks good. Something you could do is abort the build if harfbuzz-icu is not available but harfbuzz is >= 0.9.18, with:

if pkg-config --atleast-version 0.9.18 harfbuzz; then
    PKG_CHECK_MODULES(HARFBUZZ_ICU, harfbuzz-icu >= $harfbuzz_required_version)
    FREETYPE_CFLAGS+=" $HARFBUZZ_ICU_CFLAGS"
    FREETYPE_LIBS+=" $HARFBUZZ_ICU_LIBS"
fi

This is useful in case somebody builds harfbuzz but doesn't have libicu installed, as harfbuzz-icu will be automatically disabled and he may not notice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.