[Webkit-unassigned] [Bug 117008] [WK2][GTK] add new methods on WebKitSettings to enable/disable subtitles

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117008





--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2013-05-29 16:22:50 PST ---
(From update of attachment 203286)
View in context: https://bugs.webkit.org/attachment.cgi?id=203286&action=review

In principle I'm OK with this setting, I can think of browsers letting users disable subtitles even if the site wants to show them, in particular in cases in which the built-in controls (which should have a cc button that would enable/disable subtitles AFAIK) are not used, but we have been taking an approach of only adding stuff that API users are actually using, do you have a use case for this setting already?

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1134
> +

Missing *

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1136
> +     * Since: 2.3

Should be 2.2

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1143
> +            FALSE,

Any particular reason why we should not turn it on by default? I think working by default would be better.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2842
> +    bool currentValue = priv->preferences->shouldDisplaySubtitles();
> +    if (currentValue == enabled)

No reason to create a variable just for this check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.