[Webkit-unassigned] [Bug 113221] prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 29 12:23:28 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113221


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203212|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-29 12:21:59 PST ---
(From update of attachment 203212)
View in context: https://bugs.webkit.org/attachment.cgi?id=203212&action=review

> Tools/ChangeLog:13
> +        Reviewed by NOBODY (OOPS!).
> +

Reviewed by line should appear above the long description but below the bug url separated both by a single blank line as done here.

> Tools/Scripts/prepare-ChangeLog:948
> +sub does_namespaces_contain_function(\@$)

This function should probably be named either "do_namespaces_contain_function" or "is_function_in_namespaces".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list