[Webkit-unassigned] [Bug 116689] Regression(r145959) Convert <select> to new flex box causes strange positioning problems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116689





--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-05-28 20:26:31 PST ---
(From update of attachment 203104)
View in context: https://bugs.webkit.org/attachment.cgi?id=203104&action=review

> Source/WebCore/rendering/RenderMenuList.h:-126
> -    // Flexbox defines baselines differently than regular blocks.
> -    // For backwards compatibility, menulists need to do the regular block behavior.
> -    virtual int baselinePosition(FontBaseline baseline, bool firstLine, LineDirectionMode direction, LinePositionMode position) const OVERRIDE
> -    {
> -        return RenderBlock::baselinePosition(baseline, firstLine, direction, position);
> -    }
> -    virtual int firstLineBoxBaseline() const OVERRIDE { return RenderBlock::firstLineBoxBaseline(); }
> -    virtual int inlineBlockBaseline(LineDirectionMode direction) const OVERRIDE { return RenderBlock::inlineBlockBaseline(direction); }
> -

I think you need to understand why these were added before removing them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.