[Webkit-unassigned] [Bug 113221] prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 19:04:36 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113221





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-28 19:03:07 PST ---
(From update of attachment 203111)
View in context: https://bugs.webkit.org/attachment.cgi?id=203111&action=review

> Tools/ChangeLog:10
> +        (get_function_line_ranges_for_cpp): Updated to return ranges of functions 
> +        (excluding namespaces, classes, and structs) in a C++ file.

I don't think this reflect the nature or semantics of this change. It's probably better to say something along the line of
"Updated to ignore changes outside of functions".

> Tools/ChangeLog:12
> +        (delete_namespaces_from_ranges_for_cpp):
> +        (does_namespaces_contain_function):

Say "Added.".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list