[Webkit-unassigned] [Bug 113221] prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113221


Ruth Fong <ruthiecftg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ruthiecftg at gmail.com




--- Comment #8 from Ruth Fong <ruthiecftg at gmail.com>  2013-05-28 17:53:36 PST ---
The proposed patch would not generate namespace-only, class-name-only, or struct-name-only lines in C++ files. Thus, if a change is made within a namespace/class/struct yet outside a function, it will not be reflected in the ChangeLog entry with a specific function name.

Consider the sample file Source/foo/bar/sample.cpp below:
1 class Foo {
2   int x;
3   int y;
4   void bar() {
5      int z;
6   }
7 } ;

Changing lines 2-3 would result in a ChangeLog entry with the following changes denoted:

* Source/foo/bar/sample.cpp:

Notice that it will not report a change in the class Foo, i.e. (Foo) will not be included in the ChangeLog.

In contrast, changing line 5, which resides within the function bar() would result in an entry of the form:

*Source/foo/bar/sample.cpp:
(Foo::bar):

Due to the nature of this patch, it causes the unit tests used in Tools/Scripts/test-webkitperl to fail when running Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl at line 83. This is because Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt considers (Class1) as a function on lines 158-159, while the patch does not (because it's not wrapped in a function).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.