[Webkit-unassigned] [Bug 113221] prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 28 16:37:51 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113221
--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> 2013-05-28 16:36:22 PST ---
(From update of attachment 202632)
View in context: https://bugs.webkit.org/attachment.cgi?id=202632&action=review
> Tools/ChangeLog:11
> + (get_function_line_ranges_for_cpp):
> + Updated to return ranges of functions (excluding
> + namespaces, classes, and structs) in a C++ file.
"Updated to..." should appear on the right of : followed by a single space. It also seems like the line wrap should appear much later in the line.
> Tools/Scripts/prepare-ChangeLog:933
> - return @ranges;
> + my @new_ranges = delete_namespaces_from_ranges_for_cpp(@ranges, @all_namespaces);
> + return @new_ranges;
Why not "return delete_namespaces_from_ranges_for_cpp(@ranges, @all_namespaces);"?
> Tools/Scripts/prepare-ChangeLog:935
> }
>
It appears the convention in this file is to have at least two blank lines between the curly brackets that closes the previous function and a comment line for the subsequent function.
> Tools/Scripts/prepare-ChangeLog:939
> +# list of line ranges with the namespaces removed.
> +sub delete_namespaces_from_ranges_for_cpp(\@\@)
It seems like the convention in this file is to have a blank line between the last line of the comment and the first line of the corresponding function definition.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list