[Webkit-unassigned] [Bug 115647] [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115647


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |k.czech at samsung.com




--- Comment #17 from Mario Sanchez Prada <mario at webkit.org>  2013-05-28 02:12:48 PST ---
(In reply to comment #16)
> [...]
> atk_text_get_default_attributes() returns a transfer-full GSList of structs
> filled with char* pointers, meaning that you should free both the memory for
> those structs and for the GSList before returning from thie method, otherwise
> you're having a pretty nice leak here. You can check the implementation of
> AccessibilityUIElement::language in WebKitTestRunner for an already fixed
> version of the same logic (actually, I think it was already fixed for DRT too.
> I'll fix a bug about that)
       ^^^
I obviously meant "file" here :).

Anyway, just realized it doesn't make sense to file a new bug here since you are _removing_ that code from DRT and making it depend on the new method atk_object_get_object_locale(), so I won't file anything.

What I would make sense though, would be for you to also update the implementation in WebKitTestRunner's AccessibilityUIElement::language to match the one you are setting now in the DRT, so you have the correct non-leaking code in the wrapper and you just use it from DRT and WKTR.

Could you make that change too in this patch?

Note: Adding Krzysztof Czech on CC to keep him on the loop

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.