[Webkit-unassigned] [Bug 116821] isDisabledFormControl() should apply for shadow dom element also

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116821


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202971|review?                     |review-
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2013-05-27 23:03:53 PST ---
(From update of attachment 202971)
View in context: https://bugs.webkit.org/attachment.cgi?id=202971&action=review

Your patch needs a test, a description in the ChangeLog.
It looks like it also broke some tests. Make sure you run the tests before submitting something.

> Source/WebCore/dom/Element.cpp:1142
> +    Element* host = shadowHost();
> +    if (host)
> +        return host->isDisabledFormControl();

Following WebKit's style, this would be: 
if (Element* host = shadowHost())
    return host->isDisabledFormControl();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.