[Webkit-unassigned] [Bug 112615] [css3-text] Implement support for vertical writing mode in -webkit-text-underline-position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112615





--- Comment #12 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-05-27 08:17:59 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=202967&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1389
> +    return list;

You should add an assert here, list must never be empty. Besides, I do not see a need to replace CSSPrimitiveValue::CSSPrimitiveValue(TextUnderlinePosition e) with this function. This just makes your patch bigger. I see that you used one of my draft patch for text-underline-position to implement this function but since WebKit already uses CSSPrimitiveValue::CSSPrimitiveValue(TextUnderlinePosition e) you should implement your patch using it unless there is a really good reason for not to.

> Source/WebCore/css/CSSPrimitiveValueMappings.h:2468
>      // FIXME: Implement support for 'under left' and 'under right' values.

Remove obsolete comment.

> Source/WebCore/rendering/InlineTextBox.cpp:1251
> +                FloatPoint start(localOrigin.x(), localOrigin.y() + underlineOffset + (isTopSide ? -doubleOffset : doubleOffset));

We should add tests similar to LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-style.html to check for this change. Maybe a text-decoration-style-underline-left.html and text-decoration-style-underline-right.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.